RFR: JDK-8320890: [AIX] Find a better way to mimic dl handle equality [v5]
Thomas Stuefe
stuefe at openjdk.org
Mon Dec 18 10:29:52 UTC 2023
On Mon, 18 Dec 2023 10:06:34 GMT, Thomas Stuefe <stuefe at openjdk.org> wrote:
>> Joachim Kern has updated the pull request incrementally with two additional commits since the last revision:
>>
>> - trailing whitespace
>> - Following most of Thomas proposals
>
> src/hotspot/os/aix/porting_aix.cpp line 934:
>
>> 932: struct scnhdr the_scn;
>> 933: struct ldhdr the_ldr;
>> 934: size_t sz = FILHSZ + _AOUTHSZ_EXEC;
>
> please rename to xcoffsz, and make constexpr: `constexpr size_t xcoffsz = ...`
Also, can you please add
STATIC_ASSERT(sizeof(the_xcoff) == xcoffsz);
STATIC_ASSERT(sizeof(the_scn) == SCNHSZ);
STATIC_ASSERT(sizeof(the_ldr) == LDHDRSZ);
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/16920#discussion_r1429853292
More information about the serviceability-dev
mailing list