RFR: JDK-8320890: [AIX] Find a better way to mimic dl handle equality [v6]

Thomas Stuefe stuefe at openjdk.org
Tue Dec 19 12:49:42 UTC 2023


On Mon, 18 Dec 2023 13:33:46 GMT, Thomas Stuefe <stuefe at openjdk.org> wrote:

>> Joachim Kern has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Followed Thomas proposals
>
> Well done.
> 
> Releasing the mutex before asserting is not necessary; we don't pull the handle table lock as part of error reporting.

> @tstuefe Sorry to tag you. Can you review the code. Once this code goes in I can push in my changes.
We are targeting the fix for January.

> Hi @JoKern65 Is this good to integrate now ?

@suchismith1993 Please don't put pressure on patch authors and developers. There is zero reason why this patch should be rushed. 

> Hi @suchismith1993, I'm waiting for a second review. Complex hotspot changes should be reviewed twice.

Not only that, hotspot changes *need* to be reviewed by at least two reviewers. That is not optional. See OpenJDK bylaws.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/16920#issuecomment-1862695052


More information about the serviceability-dev mailing list