RFR: JDK-8320890: [AIX] Find a better way to mimic dl handle equality [v4]

[Suchismith Roy]

On Tue, 19 Dec 2023 12:52:23 GMT, Thomas Stuefe <stuefe at openjdk.org> wrote:

>> Hi @JoKern65  Is this good to integrate now ?
>
> @suchismith1993 
> 
>> Once this code goes in I can push in my changes. We are targeting the fix for January.
> 
> If you talk about https://github.com/openjdk/jdk/pull/16604, no, you cannot push that even if Joachim finishes his work.
> 
> Your patch has not even a single review, is quite controversial, and none of the issues the reviewers have mentioned are addressed. This needs a lot more discussion time.

> > @tstuefe Sorry to tag you. Can you review the code. Once this code goes in I can push in my changes.
> > We are targeting the fix for January.
> 
> > Hi @JoKern65 Is this good to integrate now ?
> 
> @suchismith1993 Please don't put pressure on patch authors and developers. There is zero reason why this patch should be rushed.
> 
> > Hi @suchismith1993, I'm waiting for a second review. Complex hotspot changes should be reviewed twice.
> 
> Not only that, hotspot changes _need_ to be reviewed by at least two reviewers. That is not optional. See OpenJDK bylaws.

Sorry about that.  The fix was critical for the adoptium builds and hence was looking to fix this soon.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/16920#issuecomment-1862776678