RFR: JDK-8322237: Heap dump contains duplicate thread records for mounted virtual threads [v2]

[Alex Menkov]

On Fri, 22 Dec 2023 00:44:16 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> Alex Menkov has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   feedback: reimplemented ThreadDumpe::is_vthread_mounted()
>
> src/hotspot/share/services/heapDumper.cpp line 1934:
> 
>> 1932:     // create a HPROF_GC_INSTANCE record for each object
>> 1933:     DumperSupport::dump_instance(writer(), o, &_class_cache);
>> 1934:     if (java_lang_VirtualThread::is_instance(o)
> 
> Suggestion. Just to be clear add a comment
> 
> // If we encounter an unmounted virtual thread it needs to be dumped explicitly.
> 
> or something to that effect. Thanks.

Thank you for review
Added comment as suggested

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/17134#discussion_r1434638886