Integrated: 8301659: Resolve initialization reordering issues on Windows for libawt and libsaproc
Julian Waters
jwaters at openjdk.org
Thu Feb 2 15:25:41 UTC 2023
On Thu, 2 Feb 2023 06:12:20 GMT, Julian Waters <jwaters at openjdk.org> wrote:
> Small, trivial change to resolve initialization order reordering in constructors, required for [JDK-8288293](https://bugs.openjdk.org/browse/JDK-8288293)
>
> gcc will fail to compile a Windows JDK with the following errors, which causes a build failure eventually:
> `GDIHashtable.cpp: m_nCounter is initialized before m_nDestroyPeriod [-Werror=reorder]` for libawt
> `sawindbg.cpp: bytePtr is initialized before releaseMode [-Werror=reorder]` for libsaproc
>
> Reordering these initializer lists to appear in the order of their declarations will resolve the build failure
This pull request has now been integrated.
Changeset: 725d57b2
Author: Julian Waters <jwaters at openjdk.org>
URL: https://git.openjdk.org/jdk/commit/725d57b2e2b78c1536d8a4adae67b27a2c8aee21
Stats: 5 lines in 2 files changed: 2 ins; 1 del; 2 mod
8301659: Resolve initialization reordering issues on Windows for libawt and libsaproc
Reviewed-by: dholmes, aivanov
-------------
PR: https://git.openjdk.org/jdk/pull/12382
More information about the serviceability-dev
mailing list