RFR: 8296646: com/sun/jdi/JdbLastErrorTest.java test failure

[Serguei Spitsyn]

On Mon, 6 Feb 2023 14:24:51 GMT, Kevin Walls <kevinw at openjdk.org> wrote:

> This test fails sometimes with ZGC. It is testing using Panama to access Windows' last error value, and can of course be interrupted by VM work that changes the value, but it does generally work. Skipping the test with ZGC is reasonable as you don't really _have_ to step through this kind of Panama code with ZGC.
> 
> More rare is a failure where "The application exited" is not observed.  This test is not here to test the exit mode, and logging that failure avoids telling you whether the correct lastError value was seen.  Test should prioritise saying if the correct last error value was observed, and should check for the exception being thrown when the correct value is not seen.

Looks good to me.
Posted one nit.
Thanks,
Serguei

test/jdk/com/sun/jdi/JdbLastErrorTest.java line 68:

> 66:             System.out.println("lastError = " + lastError);
> 67:             if (lastError != VALUE) {
> 68:                 System.err.println("iteration " + i + " gets lastError = " + lastError);

It'd be nice to print the expected VALUE as well.

-------------

Marked as reviewed by sspitsyn (Reviewer).

PR: https://git.openjdk.org/jdk/pull/12441