RFR: 8301767: Convert virtual thread tests to JUnit [v2]

Alan Bateman alanb at openjdk.org
Wed Feb 8 09:54:45 UTC 2023


On Wed, 8 Feb 2023 09:49:17 GMT, Jaikiran Pai <jpai at openjdk.org> wrote:

>> Alan Bateman has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains five commits:
>> 
>>  - Merge
>>  - Merge
>>  - Fix typos in comments
>>  - GetStackTrace.java test missing @requires vm.continuations
>>  - Initial commit
>
> test/jdk/java/lang/Thread/virtual/ThreadAPI.java line 82:
> 
>> 80:     @BeforeAll
>> 81:     static void setup() throws Exception {
>> 82:         ThreadFactory factory = Executors.defaultThreadFactory();
> 
> Unlike previously, this change now uses a `ThreadFactory` which creates non-daemon threads. Is that intentional?

It's not an issue. The `@AfterAll` finish method does the shutdown so it doesn't matter if the STPE threads are daemon or not.

-------------

PR: https://git.openjdk.org/jdk/pull/12426


More information about the serviceability-dev mailing list