Integrated: 8301767: Convert virtual thread tests to JUnit

Alan Bateman alanb at openjdk.org
Wed Feb 8 15:00:06 UTC 2023


On Sat, 4 Feb 2023 08:59:29 GMT, Alan Bateman <alanb at openjdk.org> wrote:

> The non-hotspot tests integrated with JEP 425/428 were mostly TestNG tests. We'd like to convert these JUnit in the main line in advance of other updates to these tests in 21.  The changes are mostly mechanical and trivial:
> 
> - BeforeClass/AfterClass changed to static BeforeAll/AfterAll methods
> - Tests using data providers are changed to parameterized tests
> - The order of the parameters to assertEquals are swapped so that the expected result is the first parameter
> - Usages of expectThrows are changed to assertThrows
> - Tests that threw SkipException are changed to the Assumptions API
> 
> There are a small number of drive-by changes to the tests, nothing significant, e.g.
> 
> - GetStackTrace and ParkWithFixedThreadPool changed from "@run testng" to "@run main" as they aren't TestNG tests.
> - A few of the tests in StructuredTaskScopeTest for joinXXX are changed to use a CountDownLatch rather than sleeping, as the original tests weren't very robust.

This pull request has now been integrated.

Changeset: ecf21a9a
Author:    Alan Bateman <alanb at openjdk.org>
URL:       https://git.openjdk.org/jdk/commit/ecf21a9a24d067725fda916ab197b5711c56a1d7
Stats:     1456 lines in 34 files changed: 204 ins; 79 del; 1173 mod

8301767: Convert virtual thread tests to JUnit

Reviewed-by: cstein, lancea, jpai

-------------

PR: https://git.openjdk.org/jdk/pull/12426


More information about the serviceability-dev mailing list