RFR: JDK-8302320: AsyncGetCallTrace obtains too few frames in sanity test

Johannes Bechberger duke at openjdk.org
Tue Feb 14 07:40:48 UTC 2023


On Tue, 14 Feb 2023 07:04:16 GMT, Johannes Bechberger <duke at openjdk.org> wrote:

>> src/hotspot/cpu/x86/frame_x86.cpp line 72:
>> 
>>> 70: 
>>> 71:   // unextended sp must be within the stack
>>> 72:   if (!thread->is_in_full_stack_checked(unextended_sp)) {
>> 
>> I'm not at all sure this relaxation is valid. What are you basing this on?
>
> The test fails without this relaxation and the relaxation has been used on PPC to solve a similar issue a few years back.

The original assumption does not always hold anymore and should therefore relaxed.

-------------

PR: https://git.openjdk.org/jdk/pull/12535


More information about the serviceability-dev mailing list