RFR: JDK-8301983: Refactor MEMFLAGS and AllocFailStrategy [v5]
Stefan Karlsson
stefank at openjdk.org
Tue Feb 14 09:00:55 UTC 2023
On Tue, 7 Feb 2023 17:25:02 GMT, Justin King <jcking at openjdk.org> wrote:
>> - Rename `MEMFLAGS` to `MemoryType`. `MEMFLAGS` is highly misleading as flags typically can be combined.
>> - Update `MemoryType` to have enumeration names that follow the style guide, no `mt` prefix.
>> - Create aliases for old `mtXXX` names.
>> - Remove `mt_number_of_types` from the enumeration.
>> - Shift implementation of utilities related to `MEMFLAGS` from `NMTUtil` to `MemoryTypes`. Handle missing `mt` prefix during parsing.
>> - `NMTUtil` references are not updated to avoid increasing patch size.
>> - Merge `AllocFailStrategy` and `AllocFailType` into `AllocationFailureStrategy`.
>> - Move `MemoryType` and `AllocationFailureStrategy` to their own respective headers.
>>
>> This change does not update variable verbiage. That should be something done over time.
>
> Justin King has updated the pull request incrementally with one additional commit since the last revision:
>
> Add precompiled header
>
> Signed-off-by: Justin King <jcking at google.com>
FWIW, I strongly dislike the uppercase MEMFLAGS name. I wouldn't mind this rename at all.
-------------
PR: https://git.openjdk.org/jdk/pull/12454
More information about the serviceability-dev
mailing list