RFR: JDK-8302455: VM.classloader_stats memory size values are wrong
David Holmes
dholmes at openjdk.org
Wed Feb 15 07:51:41 UTC 2023
On Tue, 14 Feb 2023 13:40:40 GMT, Thomas Stuefe <stuefe at openjdk.org> wrote:
> VM.classloader_stats shows metaspace consumption in words, but should show bytes.
>
> Patch fixes that, and adjusts the associated jtreg test to catch regressions like this.
>
> I manually tested the test with the unpatched hotspot to see if the regression shows up, it does.
>
> Tested the patch on x64 (fastdebug, release) and x86.
>
> Note: "calculate_jfr_stats" is misnamed, actually only ever used by this dcmd, not by jfr. I will clear this up in a separate RFE.
Given the reason this bug likely arose is the fact the parameters to `calculate_jfr_stats` say they are "bytes" then fixing that is not a mere cleanup IMO. Can we at least fix that in this PR?
-------------
PR: https://git.openjdk.org/jdk/pull/12556
More information about the serviceability-dev
mailing list