RFR: JDK-8302455: VM.classloader_stats memory size values are wrong [v3]

David Holmes dholmes at openjdk.org
Thu Feb 16 01:29:42 UTC 2023


On Wed, 15 Feb 2023 10:50:11 GMT, Thomas Stuefe <stuefe at openjdk.org> wrote:

>> VM.classloader_stats shows metaspace consumption in words, but should show bytes. 
>> 
>> Patch fixes that, and adjusts the associated jtreg test to catch regressions like this.
>> 
>> I manually tested the test with the unpatched hotspot to see if the regression shows up, it does.
>> 
>> Tested the patch on x64 (fastdebug, release) and x86.
>> 
>> Note: "calculate_jfr_stats" is misnamed, actually only ever used by this dcmd, not by jfr. I will clear this up in a separate RFE.
>
> Thomas Stuefe has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Fix -UseCCP and add regression test

Looks good. The `usage_numbers` changes were a bit more involved then I had expected but they seem fine.

Thanks.

-------------

Marked as reviewed by dholmes (Reviewer).

PR: https://git.openjdk.org/jdk/pull/12556


More information about the serviceability-dev mailing list