RFR: JDK-8302320: AsyncGetCallTrace obtains too few frames in sanity test [v3]
David Holmes
dholmes at openjdk.org
Sun Feb 19 22:10:25 UTC 2023
On Fri, 17 Feb 2023 14:47:56 GMT, Johannes Bechberger <duke at openjdk.org> wrote:
>> Extends the existing AsyncGetCallTrace test case and fixes the issue.
>
> Johannes Bechberger has updated the pull request incrementally with one additional commit since the last revision:
>
> Revert previous change
I'm somewhat concerned that the code doesn't seem to have a clear notion of exactly how `unextended_sp` relates to `sp` in general. I would still be concerned that the relaxation may cause a bad value to be considered safe and so lead to a crash. But I guess we will just have to address that if it arises.
Thanks for all the due-diligence on this one.
-------------
PR: https://git.openjdk.org/jdk/pull/12535
More information about the serviceability-dev
mailing list