RFR: JDK-8302320: AsyncGetCallTrace obtains too few frames in sanity test [v3]

Johannes Bechberger duke at openjdk.org
Mon Feb 20 09:03:29 UTC 2023


On Mon, 20 Feb 2023 08:46:43 GMT, Richard Reingruber <rrich at openjdk.org> wrote:

>> Johannes Bechberger has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Revert previous change
>
> src/hotspot/cpu/x86/frame_x86.cpp line 75:
> 
>> 73:   // interpreted -> interpreted calls that go through a method handle linker,
>> 74:   // since those pop the last argument (the appendix) from the stack.
>> 75:   if (!thread->is_in_full_stack_checked(unextended_sp)) {
> 
> The condition can remain stricter. The following should work too. Could you please check?
> Suggestion:
> 
>   if (!thread->is_in_stack_range_incl(unextended_sp + Interpreter::stackElementSize, sp)) {

The sanity test worked :)

-------------

PR: https://git.openjdk.org/jdk/pull/12535


More information about the serviceability-dev mailing list