RFR: JDK-8302320: AsyncGetCallTrace obtains too few frames in sanity test [v3]
Johannes Bechberger
duke at openjdk.org
Mon Feb 20 09:14:25 UTC 2023
On Mon, 20 Feb 2023 09:08:59 GMT, Richard Reingruber <rrich at openjdk.org> wrote:
>> ... and no regression in the other serviceability tests.
>
> Probably it's better to adapt the limit though (sorry).
> Problem with this version is that it allows `unextended_sp` outside the address range reserved for the stack. Let's see what other reviewers think.
> Suggestion:
>
> if (!thread->is_in_stack_range_incl(unextended_sp, sp - Interpreter::stackElementSize)) {
Good point, you're right. I could have recognized this myself.
-------------
PR: https://git.openjdk.org/jdk/pull/12535
More information about the serviceability-dev
mailing list