RFR: 8299234: JMX Repository.query performance [v5]

[Serguei Spitsyn]

On Fri, 17 Feb 2023 17:33:19 GMT, Kevin Walls <kevinw at openjdk.org> wrote:

>> Alexey Bakhtin has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Optimize ObjectName.matchDomains
>
> Yes, I think it looks good.
> I looked a while ago but it was somewhat unfamiliar so was glad of Daniel's input.
> 
> It's a bit of a style nit but our ifs always use brackets, so I miss that in ObjectName.matchDomains(), particularly as the statements are multi-line.
> 
> I tested the change with test/jdk/javax/management/ and everything still passes.
> The repo is somewhat behind, but these changes have no merge problems with the latest. I took these changes into a latest jdk repo to build and test.

> @kevinjwalls, Thank you very much for reviewing. @sspitsyn, the patch is approved by Kevin but unfortunately, he is not a reviewer in JDK project. Could you please approve it or ask somebody from the serviceability group? Thank you in advance.

Alexey, two reviews are normally required before integration in the Serviceability area.
I guess, you need to wait for review from Daniel Fuchs (an expert in this area) or someone else.

-------------

PR: https://git.openjdk.org/jdk/pull/11758