RFR: JDK-8302320: AsyncGetCallTrace obtains too few frames in sanity test [v5]
Jorn Vernee
jvernee at openjdk.org
Mon Feb 20 14:13:27 UTC 2023
On Mon, 20 Feb 2023 09:18:46 GMT, Johannes Bechberger <duke at openjdk.org> wrote:
>> Extends the existing AsyncGetCallTrace test case and fixes the issue.
>
> Johannes Bechberger has updated the pull request incrementally with one additional commit since the last revision:
>
> Improve condition again
The new check looks good to me. I think the only potential issue is in cases where `unextended_sp == sp` and `sp - Interpreter::stackElementSize` is somehow outside of the stack. But, since this is looking at a sender, it would mean that the current frame would definitely be outside of the stack, so I think we're good.
I'll submit tier 1-4 on our CI, and give a check mark when it comes back green.
-------------
PR: https://git.openjdk.org/jdk/pull/12535
More information about the serviceability-dev
mailing list