RFR: 8302870: More information needed from failures in vmTestbase ThreadUtils.waitThreadState
David Holmes
dholmes at openjdk.org
Mon Feb 20 22:39:30 UTC 2023
On Mon, 20 Feb 2023 22:30:30 GMT, David Holmes <dholmes at openjdk.org> wrote:
>> Test update to make failures such as JDK-8076494 more informative.
>>
>> Waiting for a thread to change state: give more time (to distinguish a real deadlock from some other delay), and log the thread stackframes when the expected state change is not observed.
>
> test/hotspot/jtreg/vmTestbase/nsk/monitoring/share/thread/ThreadUtils.java line 232:
>
>> 230:
>> 231: // Most uses of waitThreadState usually succeed without retries.
>> 232: // Sleep time increased to help avoid spurious failures.
>
> "increased" doesn't mean anything outside this PR as you can't tell the value has changed.
Also any comment on sleep time belongs after line 233.
-------------
PR: https://git.openjdk.org/jdk/pull/12661
More information about the serviceability-dev
mailing list