RFR: 8300575: JVMTI support when using alternative virtual thread implementation [v7]

Tue Feb 21 18:02:26 UTC 2023

On Sat, 18 Feb 2023 07:56:25 GMT, Alan Bateman <alanb at openjdk.org> wrote:

>>> Thanks for dropping is_bound_vthread, I think it's much better now. What would you think about changing it to test the thread type is_a vmClasses::BaseVirtualThread_klass() so the VM doesn't need to know about ThreadBuilders$BoundVirtualThread.
>>>
>> Yes, we could do that. Although I think that checking for BoundVirtualThread_klass is more descriptive of what we are trying to do and will be less confusing when reading the code. How about checking for `(!VMContinuations && x->is_a(vmClasses::BaseVirtualThread_klass()))`?
>
>> Yes, we could do that. Although I think that checking for BoundVirtualThread_klass is more descriptive of what we are trying to do and will be less confusing when reading the code. How about checking for `(!VMContinuations && x->is_a(vmClasses::BaseVirtualThread_klass()))`?
> 
> We can go with what you have for now and re-visit again if it becomes an issue. The main thing I had hoped is that the VM won't get too coupled to BoundVirtualThread as that may move or be refactored soon.

Thanks for the reviews @AlanBateman, @lmesnik and @sspitsyn!

-------------

PR: https://git.openjdk.org/jdk/pull/12512