RFR: 8303169: Remove Windows specific workaround from libdt

Julian Waters jwaters at openjdk.org
Sat Feb 25 15:32:03 UTC 2023


On Fri, 24 Feb 2023 15:36:36 GMT, Julian Waters <jwaters at openjdk.org> wrote:

> We no longer need to define PrId64 ourselves since the Visual C++ compiler supports inttypes.h on the only versions we support, so we can just replace it with an include to the standard header instead

Little bit of a quick note from me before integration, I found it strange that for other platforms no inttypes.h include was needed for PRId64 to work properly, but after more in depth checking to see whether the inttypes.h include should go elsewhere to match where the other platforms have it, apparently this is a Windows only library, making it all the more strange that a Windows conditional define was here at all in the first place. Just to be extra safe, is there confirmation that this will always be Windows only, and the the shared native code is somehow a mistake or leftover from long ago?

-------------

PR: https://git.openjdk.org/jdk/pull/12744


More information about the serviceability-dev mailing list