RFR: 8303267: Prefer ArrayList to LinkedList in ConcurrentLocksPrinter

Serguei Spitsyn sspitsyn at openjdk.org
Tue Feb 28 07:00:01 UTC 2023


On Mon, 27 Feb 2023 12:54:24 GMT, Andrey Turbanov <aturbanov at openjdk.org> wrote:

> LinkedList is used as value in `sun.jvm.hotspot.runtime.ConcurrentLocksPrinter#locksMap` Map.
> There is only add/iterator calls on this lists. No removes from the head or something like this. Not sure why LinkedList was used, but ArrayList should be preferred as more efficient and widely used collection.
> 
> Also I've done some related code cleaned:
> 1. Mark field `locksMap` as final
> 2. Use Map.computeIfAbsent
> 3. Use enhanced-for cycle instead of `for` with iterator

Looks good.
Thanks,
Serguei

-------------

Marked as reviewed by sspitsyn (Reviewer).

PR: https://git.openjdk.org/jdk/pull/12763


More information about the serviceability-dev mailing list