RFR: 8299518: HotSpotVirtualMachine shared code across different platforms

[David Holmes]

On Tue, 3 Jan 2023 09:34:55 GMT, Yi Yang <yyang at openjdk.org> wrote:

> harmless refactor to share code across different platforms of VirtualMachineImpl:
> 1. Shared code to process command response after requesting a command execution
> 2. Read functionality in SocketInputStream can be reused

There are a lot of stylistic changes here that have nothing to do with refactoring or code sharing and they make the real changes very hard to see. At a minimum things like variable renaming should be done in a separate commit, so the refactoring is more obvious, but it may be better to use a separate cleanup RFE.

src/jdk.attach/aix/classes/sun/tools/attach/VirtualMachineImpl.java line 59:

> 57: 
> 58:         // This provider only understands pids
> 59:         int pid = Integer.parseInt(vmid);

This will now throw `NumberFormatException` instead of the expected `AttachNotSupportedException`.

-------------

PR: https://git.openjdk.org/jdk/pull/11823