RFR: JDK-8299470: sun/jvm/hotspot/SALauncher.java handling of negative rmiport args [v3]

Matthias Baesken mbaesken at openjdk.org
Wed Jan 4 14:27:48 UTC 2023


On Wed, 4 Jan 2023 14:19:18 GMT, Kevin Walls <kevinw at openjdk.org> wrote:

> In the "if (useRmiPort) {" block, we should be failing the test if rmiPort is -1, saying something like "cannot find an rmiPort, findUnreservedFreePort returns -1"
> 
> A similar abort if setting registryPort gets -1 might also be good?

Hi Kevin,  I think you are correct, adjusting the  test test/hotspot/jtreg/serviceability/sa/sadebugd/SADebugDTest.java  in those two cases (rmiPort / registryPort  -1)  probably makes sense.  Should we do it in another JBS issue or here ?
Additionally , should we fail the test in these cases , or pass with some warning - message ?

-------------

PR: https://git.openjdk.org/jdk/pull/11811


More information about the serviceability-dev mailing list