RFR: 8299518: HotSpotVirtualMachine shared code across different platforms [v2]
Yi Yang
yyang at openjdk.org
Thu Jan 5 02:53:50 UTC 2023
On Wed, 4 Jan 2023 04:20:11 GMT, David Holmes <dholmes at openjdk.org> wrote:
> In that case the `int pid` determined by the superclass should be made available to the subclasses so they can use it and not need to re-parse the `vmid`.
Hi @dholmes-ora, this is feasible, but in fact, the super class of VirtualMachine has already saved an unresolved pid(String) and corresponding getter method, so if we want to avoid re-parsing pid, we should save this parsed result in the parent class of the parent class of VirtualMachineImpl, and then modify the corresponding method, which seems to be beyond the scope of simple refactoring, so I hope avoiding re-parsing can be done by another PR
-------------
PR: https://git.openjdk.org/jdk/pull/11823
More information about the serviceability-dev
mailing list