RFR: 8299518: HotSpotVirtualMachine shared code across different platforms [v2]

[David Holmes]

On Thu, 5 Jan 2023 02:35:54 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> Yi Yang has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR. The pull request contains two new commits since the last revision:
>> 
>>  - separate renaming
>>  - 8299518: HotSpotVirtualMachine shared code across different platforms
>
> src/jdk.attach/linux/classes/sun/tools/attach/VirtualMachineImpl.java line 195:
> 
>> 193:      * InputStream for the socket connection to get target VM
>> 194:      */
>> 195:     private static class SocketInputStreamImpl extends SocketInputStream {
> 
> Can this class definition also be shared by making it a protected nested class in the superclass?

Sorry I see it already is, but I think we can do better.

-------------

PR: https://git.openjdk.org/jdk/pull/11823