RFR: 8299518: HotSpotVirtualMachine shared code across different platforms [v3]
Yi Yang
yyang at openjdk.org
Thu Jan 5 03:38:49 UTC 2023
On Thu, 5 Jan 2023 03:06:20 GMT, David Holmes <dholmes at openjdk.org> wrote:
>> All Posix OS platforms call the same VirtualMachineImpl.read/write/etc, but Windows is an unusual guy, it calls VirtualMachineImpl.readPipe/writePipe/etc
>
> That is a shame, though perhaps we could just rename those methods on Windows?
>
> This also raises the obvious question can we in fact reduce this to just a Windows and Posix version, or are there other differences between Linux, macOS etc that have to be accounted for? Though in that case we could introduce a shared superclass for the Posix platforms. Next steps perhaps?
The remaining code for the POSIX system is exactly the same, except that Linux will make an extra attempt to find java_pid in cgroup environment.
-------------
PR: https://git.openjdk.org/jdk/pull/11823
More information about the serviceability-dev
mailing list