RFR: JDK-8299470: sun/jvm/hotspot/SALauncher.java handling of negative rmiport args [v5]

[Kevin Walls]

On Wed, 4 Jan 2023 15:30:10 GMT, Matthias Baesken <mbaesken at openjdk.org> wrote:

>> The test serviceability/sa/sadebugd/SADebugDTest.java can pass under some circumstances a negative rmiport (--rmiport -1) to SALauncher.java.
>> This leads to a somewhat misleading message 
>> `[debugd] Argument is expected for 'rmiport' `
>> (we set an argument [-1] but probably this is not what is really expected) and additionally the real exception is not shown.
>> Probably also a warning in case of negative rmiport values should be printed because they seem to lead to errors.
>
> Matthias Baesken has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Small output adjustments

Marked as reviewed by kevinw (Committer).

Thanks for updating. 
I do think we should remove the e.printStackTrace() that was added in src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/SALauncher.java
as this is a message for the user.
In the test, those new RuntimeExceptions will produce a stacktrace for when we look at the failing test.

-------------

PR: https://git.openjdk.org/jdk/pull/11811