RFR: 8299518: HotSpotVirtualMachine shared code across different platforms [v4]
Andrey Turbanov
aturbanov at openjdk.org
Mon Jan 9 08:00:55 UTC 2023
On Mon, 9 Jan 2023 03:29:04 GMT, Yi Yang <yyang at openjdk.org> wrote:
>> harmless refactor to share code across different platforms of VirtualMachineImpl:
>> 1. Shared code to process command response after requesting a command execution
>> 2. Read functionality in SocketInputStream can be reused
>
> Yi Yang has updated the pull request incrementally with two additional commits since the last revision:
>
> - describe parameter
> - Revert "separate renaming"
>
> This reverts commit cb700000ac62fdfa605ed4f9e415c4ab73bfc8a3.
src/jdk.attach/share/classes/sun/tools/attach/HotSpotVirtualMachine.java line 422:
> 420: * InputStream for the socket connection to get target VM
> 421: */
> 422: static abstract class SocketInputStream extends InputStream {
Use blessed modifiers order
Suggestion:
abstract static class SocketInputStream extends InputStream {
-------------
PR: https://git.openjdk.org/jdk/pull/11823
More information about the serviceability-dev
mailing list