RFR: 8299853: Serial: Use more concrete type for TenuredGeneration::_the_space
Stefan Karlsson
stefank at openjdk.org
Tue Jan 10 12:40:55 UTC 2023
On Tue, 10 Jan 2023 10:51:14 GMT, Albert Mingkun Yang <ayang at openjdk.org> wrote:
> Simple change of using the actual type for a field.
>
> Test: hotspot_gc
Looks good. Some nits:
src/hotspot/share/gc/serial/tenuredGeneration.hpp line 68:
> 66: void assert_correct_size_change_locking();
> 67:
> 68: TenuredSpace* _the_space; // Actual space holding objects
Indentation is weird after this change
src/hotspot/share/gc/shared/cardTableRS.hpp line 35:
> 33: class Generation;
> 34: class Space;
> 35: class TenuredSpace;
Since you are changing this, could you add a blank line after this line?
-------------
Marked as reviewed by stefank (Reviewer).
PR: https://git.openjdk.org/jdk/pull/11925
More information about the serviceability-dev
mailing list