RFR: 8300012: Remove unused JDI VirtualMachineImpl.removeObjectMirror(ObjectReferenceImpl object) method

Alan Bateman alanb at openjdk.org
Thu Jan 12 08:09:14 UTC 2023


On Thu, 12 Jan 2023 02:20:04 GMT, Chris Plummer <cjplummer at openjdk.org> wrote:

> `VirtualMachineImpl.removeObjectMirror(ObjectReferenceImpl object)` is not used. Furthermore it confuses the reader that runs across `removeObjectMirror()` calls, because what is actually being called is `removeObjectMirror(SoftObjectReference ref)`.

Marked as reviewed by alanb (Reviewer).

src/jdk.jdi/share/classes/com/sun/tools/jdi/VirtualMachineImpl.java line 1448:

> 1446:     }
> 1447: 
> 1448:     synchronized void removeObjectMirror(SoftObjectReference ref) {

It might able help to make this method removeObjectMirror, this will make it clear that the method can't be called from code in other source files in this package.

-------------

PR: https://git.openjdk.org/jdk/pull/11957


More information about the serviceability-dev mailing list