RFR: 8300032: DwarfParser resource leak

[Serguei Spitsyn]

On Thu, 12 Jan 2023 12:08:51 GMT, Daniel Jeliński <djelinski at openjdk.org> wrote:

> Please review this fix for DwarfParser cleaner.
> 
> The original code registered the cleaner using a lambda that captured a reference to the parser object; as a result, the object was never GCed, and the cleaner never ran.
> 
> In this version I moved the lambda creation to a static method, so that it can't capture a reference to the parser.
> 
> Additionally, the new code uses a static cleaner; the cleaner object creation and cleanup are heavy operations (every cleaner comes with its own thread), and it's preferable to use a single shared cleaner where possible.
> 
> I verified manually that the native `destroyDwarfContext` method is called after this fix. No new automated test. Existing tier1-2 tests continue to pass.

This looks good modulo there can be more issues like that as Chris mentioned.
Thanks,
Serguei

-------------

Marked as reviewed by sspitsyn (Reviewer).

PR: https://git.openjdk.org/jdk/pull/11965