RFR: 8300024: Replace use of JNI_COMMIT mode with mode 0
Serguei Spitsyn
sspitsyn at openjdk.org
Fri Jan 13 04:02:58 UTC 2023
On Thu, 12 Jan 2023 09:23:49 GMT, Daniel Jeliński <djelinski at openjdk.org> wrote:
> Please review this patch that fixes a few memory leaks in JNI code.
>
> [The latest documentation](https://docs.oracle.com/en/java/javase/17/docs/specs/jni/functions.html#releaseprimitivetypearrayelements-routines) of JNI functions makes an explicit note about the use of JNI_COMMIT:
>
>> If `JNI_COMMIT` is passed as the `mode` argument when `elems` is a copy of the elements in `array`, then a final call to *Release<PrimitiveType\>ArrayElements* passing a `mode` argument of "0" or `JNI_ABORT`, should be made to free the `elems` buffer
>
> No new regression test. I manually verified the Linux fix using ClhdsbPstack test in root mode. Also, tier1-2 tests on mach5 continue to pass.
Marked as reviewed by sspitsyn (Reviewer).
Looks good.
Thank you for taking care about it.
Serguei
-------------
PR: https://git.openjdk.org/jdk/pull/11963
More information about the serviceability-dev
mailing list