RFR: 8300012: Remove unused JDI VirtualMachineImpl.removeObjectMirror(ObjectReferenceImpl object) method [v2]

Serguei Spitsyn sspitsyn at openjdk.org
Fri Jan 13 04:03:04 UTC 2023


On Thu, 12 Jan 2023 16:44:44 GMT, Chris Plummer <cjplummer at openjdk.org> wrote:

>> `VirtualMachineImpl.removeObjectMirror(ObjectReferenceImpl object)` is not used. Furthermore it confuses the reader that runs across `removeObjectMirror()` calls, because what is actually being called is `removeObjectMirror(SoftObjectReference ref)`.
>
> Chris Plummer has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Make removeObjectMirror() private.

Looks good and simple. :)
Thanks,
Serguei

-------------

Marked as reviewed by sspitsyn (Reviewer).

PR: https://git.openjdk.org/jdk/pull/11957


More information about the serviceability-dev mailing list