RFR: 8299635: More test issues for deprecated sprintf in Xcode 14 [v2]
Mikael Vidstedt
mikael at openjdk.org
Sat Jan 14 00:44:11 UTC 2023
On Fri, 13 Jan 2023 23:27:36 GMT, Xue-Lei Andrew Fan <xuelei at openjdk.org> wrote:
>> The sprintf is deprecated in Xcode 14 because of security concerns. The issue was addressed in [JDK-8296812](https://bugs.openjdk.org/browse/JDK-8296812) for hotspot impl, and [JDK-8299378](https://bugs.openjdk.org/browse/JDK-8299378) for building, but the test case was not covered. The failure was reported in [PR 11793](https://github.com/openjdk/jdk/pull/11793#issuecomment-1371151565), while running tier1 testing.
>>
>> This patch is trying to find the use of sprintf in test cases, and replace it with snprintf accordingly.
>
> Xue-Lei Andrew Fan has updated the pull request incrementally with one additional commit since the last revision:
>
> more in src/hotspot
Thank you for making these additional changes! I'm still seeing some issue building on linux-x64, for example:
src/hotspot/share/opto/regalloc.hpp:130:17: note: candidate: 'virtual char* PhaseRegAlloc::dump_register(const Node*, char*, size_t) const'
130 | virtual char *dump_register( const Node *n, char *buf, size_t buf_size) const = 0;
| ^~~~~~~~~~~~~
-------------
PR: https://git.openjdk.org/jdk/pull/11935
More information about the serviceability-dev
mailing list