RFR: 8292741: Convert JvmtiTagMapTable to ResourceHashtable [v10]

[David Holmes]

On Wed, 11 Jan 2023 10:49:59 GMT, Afshin Zafari <duke at openjdk.org> wrote:

>> test of tier1-5 passed.
>
> Afshin Zafari has updated the pull request incrementally with one additional commit since the last revision:
> 
>   8292741: Convert JvmtiTagMapTable to ResourceHashtable

Still have a couple of nits regarding comments and some uncertainty about API use/behaviour. But okay. Thanks for the updates.

src/hotspot/share/prims/jvmtiTagMapTable.cpp line 80:

> 78:     }
> 79:   } remove_all;
> 80:   _table.unlink(&remove_all);

This logic is a bit unclear - can you add some comments. I guess I need to understand what unlink does when reading this code.

src/hotspot/share/prims/jvmtiTagMapTable.cpp line 101:

> 99:   JvmtiTagMapKey jtme(obj);
> 100:   jlong* found = _table.get(jtme);
> 101:   return found == NULL ? 0 : *found;

Please use nullptr in new code

-------------

Marked as reviewed by dholmes (Reviewer).

PR: https://git.openjdk.org/jdk/pull/11288