RFR: 8299795: Relativize locals in interpreter frames [v4]

Andrew Haley aph at openjdk.org
Wed Jan 18 10:16:33 UTC 2023


On Tue, 17 Jan 2023 08:35:45 GMT, Fredrik Bredberg <duke at openjdk.org> wrote:

>> Implementation of relativized locals in interpreter frames for x86. x64, arm, aarch64, ppc64le and riscv.
>> Not relativized locals on zero and s390 but done some changes to cope with the changed generic code.
>> Tested tier1-tier8 on supported platforms. The rest was sanity tested using Qemu, except s390, which was only tested by GitHub Actions.
>
> Fredrik Bredberg has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains five additional commits since the last revision:
> 
>  - Merge branch 'master' into relativize-locals-JDK-8299795_2023-01-09
>  - Added references to JDK-8300197
>  - Updated some copyright dates.
>  - Changed copyright date to 2023
>  - 8299795: Relativize locals in interpreter frames

src/hotspot/cpu/aarch64/continuationFreezeThaw_aarch64.inline.hpp line 236:

> 234:     caller.set_sp(fp + frame::sender_sp_offset);
> 235:     frame f(frame_sp, frame_sp, fp, hf.pc());
> 236:     // we need to set the locals now so that the caller of new_stack_frame() can call

Suggestion:

    // we need to set the locals so that the caller of new_stack_frame() can call

-------------

PR: https://git.openjdk.org/jdk/pull/11902


More information about the serviceability-dev mailing list