[jdk20] RFR: 8299891: JMX ObjectInputFilter additional classes needed [v2]

Daniel Fuchs dfuchs at openjdk.org
Wed Jan 18 18:00:24 UTC 2023


On Wed, 18 Jan 2023 17:56:43 GMT, Kevin Walls <kevinw at openjdk.org> wrote:

>> The default setting for the ObjectInputFilter for JMX, introduced in jdk20, is too restrictive.
>> javax.management.Attribute and AttributeList classes are also needed, and Query related classes.
>> 
>> There are a number of Query-relate classes, so adding javax.management.* is appropriate otherwise the list becomes hard to manage.  This is a * and not a ** which would mean all subpackages, so the openmean subpackage stays in the list.
>
> Kevin Walls has updated the pull request incrementally with two additional commits since the last revision:
> 
>  - filter properties update: more classes logged as ALLOWED during wider testing
>  - Add a Notification test

Thanks for adding the new testcases, especially WRT to notifications.
Your filter might be a little wider than strictly required but it looks like a good first step, and is obviously better than no filter. I am approving on the condition that all JMX (and JCK?) tests are stable passing.
Please obtain approval from a maintainer of this area before pushing.

-------------

Marked as reviewed by dfuchs (Reviewer).

PR: https://git.openjdk.org/jdk20/pull/97


More information about the serviceability-dev mailing list