RFR: 8299635: Hotspot update for deprecated sprintf in Xcode 14 [v5]

[Xue-Lei Andrew Fan]

On Tue, 17 Jan 2023 01:34:49 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> Xue-Lei Andrew Fan has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains six additional commits since the last revision:
>> 
>>  - Merge
>>  - correction for ppc
>>  - missed update for debug mode
>>  - more in src/hotspot
>>  - typo correction
>>  - 8299635: More test issues for deprecated sprintf in Xcode 14
>
> src/hotspot/share/utilities/globalDefinitions.hpp line 191:
> 
>> 189: FORBID_C_FUNCTION(char* strerror(int), "use os::strerror");
>> 190: FORBID_C_FUNCTION(char* strtok(char*, const char*), "use strtok_r");
>> 191: FORBID_C_FUNCTION(int sprintf(char*, const char*, ...), "use os::snprintf");
> 
> I have to wonder whether this actually works too. Perhaps @kbarrett can comment?

I am not confident with it.  Maybe it is better to remove this change and consider it later.

-------------

PR: https://git.openjdk.org/jdk/pull/11935