RFR: 8299635: Hotspot update for deprecated sprintf in Xcode 14 [v5]

Chris Plummer cjplummer at openjdk.org
Wed Jan 18 19:48:18 UTC 2023


On Wed, 18 Jan 2023 19:28:42 GMT, Xue-Lei Andrew Fan <xuelei at openjdk.org> wrote:

>> I think the other acceptable approach is to put the first argument on the 2nd line, and then indent all the argument lines by 8. That works well if the first argument would otherwise start too far to the right. For the above, I think either approach would look ok.
>
> I can see both styles are used in this file.  The current code here uses 8 whitespaces indent, I would like to keep it.

I scanned the first 1000 lines and saw many cases of multi-line argument passing, and they all indent as David suggested. I'm not saying there are non in the file that indent has you have, but it seems if there are cases, they are the exception.

-------------

PR: https://git.openjdk.org/jdk/pull/11935


More information about the serviceability-dev mailing list