RFR: 8299635: Hotspot update for deprecated sprintf in Xcode 14 [v6]

[David Holmes]

On Wed, 18 Jan 2023 19:41:11 GMT, Xue-Lei Andrew Fan <xuelei at openjdk.org> wrote:

>> The sprintf is deprecated in Xcode 14 because of security concerns. The issue was addressed in [JDK-8296812](https://bugs.openjdk.org/browse/JDK-8296812) for hotspot impl, and [JDK-8299378](https://bugs.openjdk.org/browse/JDK-8299378) for building, but the test case was not covered. The failure was reported in [PR 11793](https://github.com/openjdk/jdk/pull/11793#issuecomment-1371151565), while running tier1 testing.
>> 
>> This patch is trying to find the use of sprintf in hotspot iml and test cases.
>
> Xue-Lei Andrew Fan has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Remove FORBID_C_FUNCTION update

src/hotspot/share/utilities/globalDefinitions.hpp line 191:

> 189: FORBID_C_FUNCTION(char* strerror(int), "use os::strerror");
> 190: FORBID_C_FUNCTION(char* strtok(char*, const char*), "use strtok_r");
> 191: FORBID_C_FUNCTION(int vsprintf(char*, const char*, va_list), "use os::vsnprintf");

At some point we would want this and as this should be the last PR to touch hotspot code in this area then this seems like the right PR to have it in. We just need to check that it is actually working as expected.

-------------

PR: https://git.openjdk.org/jdk/pull/11935