RFR: JDK-8300245: Replace NULL with nullptr in share/jfr/

[Markus Grönlund]

On Thu, 19 Jan 2023 20:44:33 GMT, Johan Sjölen <jsjolen at openjdk.org> wrote:

>> Do the conversion in the share/jfr/ sub-directory and all of its files.
>
> src/hotspot/share/jfr/instrumentation/jfrEventClassTransformer.cpp line 1157:
> 
>> 1155:   const int orig_stream_length = orig_stream->length();
>> 1156:   // allocate an identically sized buffer
>> 1157:   u1* const new_buffer = NEW_RESOURCE_ARRAY_IN_THREAD_RETURN_nullptr(THREAD, u1, orig_stream_length);
> 
> fix

Propagating the term "nullptr" is weird when it is used conceptually, like for example in comments and macros.

> src/hotspot/share/jfr/instrumentation/jfrEventClassTransformer.cpp line 1558:
> 
>> 1556:   const jint stream_len = new_stream->length();
>> 1557:   JvmtiCachedClassFileData* p =
>> 1558:     (JvmtiCachedClassFileData*)NEW_C_HEAP_ARRAY_RETURN_nullptr(u1, offset_of(JvmtiCachedClassFileData, data) + stream_len, mtInternal);
> 
> fix

Not sure agree about the new macro. Why not in capitals, if it needs to be updated (which I am not sure it has)?

> src/hotspot/share/jfr/writers/jfrEncoding.hpp line 33:
> 
>> 31: 
>> 32: enum JfrStringEncoding {
>> 33:   nullptr_STRING = 0,
> 
> fix

This is a conceptual "NULL" more than a specific C++ nullptr.

-------------

PR: https://git.openjdk.org/jdk/pull/12034