RFR: 8299234: JMX Repository.query performance [v3]

[Daniel Fuchs]

On Wed, 11 Jan 2023 14:09:21 GMT, Alexey Bakhtin <abakhtin at openjdk.org> wrote:

>> Please find a patch to improve JMX Repository.query performance
>> 
>> Using ObjectName.apply() allows significantly decrease memory usage and the number of GC cycles:
>> Before:
>> 
>> $ java test 1000000 1000000
>> Test PASSED in 8943169791 ns.
>> GC: G1 Young Generation getCollectionCount()=177 getCollectionTime()=118
>> 
>> 
>> After:
>> 
>> $ java test 1000000 1000000
>> Test PASSED in 4808213917 ns.
>> GC: G1 Young Generation getCollectionCount()=88 getCollectionTime()=53
>> 
>> Private ObjectName.matchDomains() method is also updated to minimize unnecessary memory allocation.
>> 
>> All javax/management jtreg tests passed successfully.
>
> Alexey Bakhtin has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Fix parameters order for Util.wildmatch

Hi Alexey - you have addressed most of my concerns but let me reinstate that the changes to ObjectName are observable by subclasses and thus will require a CSR. As such this fix may also not be a good candidate for backport (if that was your intention), as it comes with a potential regression risk.

-------------

PR: https://git.openjdk.org/jdk/pull/11758