RFR: 8301132: Test update for deprecated sprintf in Xcode 14 [v2]

Xue-Lei Andrew Fan xuelei at openjdk.org
Fri Jan 27 05:27:42 UTC 2023


On Thu, 26 Jan 2023 18:07:42 GMT, Mikael Vidstedt <mikael at openjdk.org> wrote:

>> Xue-Lei Andrew Fan has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   incorrect use of sizeof
>
> test/jdk/sun/management/windows/exerevokeall.c line 102:
> 
>> 100: 
>> 101:     // S-SID_REVISION
>> 102:     snprintf(name, sizeof(name), "S-%lu-", SID_REVISION );
> 
> Name is a `char *` so sizeof will return the size of the pointer, not the length of the allocate data.

Ooooops.  Thank you for the catch!

-------------

PR: https://git.openjdk.org/jdk/pull/12211


More information about the serviceability-dev mailing list