RFR: 8299234: JMX Repository.query performance [v4]

Daniel Fuchs dfuchs at openjdk.org
Mon Jan 30 15:33:19 UTC 2023


On Mon, 23 Jan 2023 20:25:17 GMT, Alexey Bakhtin <abakhtin at openjdk.org> wrote:

>> Please find a patch to improve JMX Repository.query performance
>> 
>> Using ObjectName.apply() allows significantly decrease memory usage and the number of GC cycles:
>> Before:
>> 
>> $ java test 1000000 1000000
>> Test PASSED in 8943169791 ns.
>> GC: G1 Young Generation getCollectionCount()=177 getCollectionTime()=118
>> 
>> 
>> After:
>> 
>> $ java test 1000000 1000000
>> Test PASSED in 4808213917 ns.
>> GC: G1 Young Generation getCollectionCount()=88 getCollectionTime()=53
>> 
>> Private ObjectName.matchDomains() method is also updated to minimize unnecessary memory allocation.
>> 
>> All javax/management jtreg tests passed successfully.
>
> Alexey Bakhtin has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Revert changes in the ObjectName

I don't see an obvious issue with the proposed changes. Do you have a JMH benchmark to prove the new code is faster? Also please obtain a review from a maintainer of the servicieability area before integrating.

-------------

PR: https://git.openjdk.org/jdk/pull/11758


More information about the serviceability-dev mailing list