RFR: 8311301: MethodExitTest may fail with stack buffer overrun [v2]

Daniel Jeliński djelinski at openjdk.org
Thu Jul 6 08:57:07 UTC 2023


On Thu, 6 Jul 2023 07:08:00 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> Daniel Jeliński has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Use void* instead
>
> test/hotspot/jtreg/serviceability/jvmti/vthread/MethodExitTest/libMethodExitTest.cpp line 127:
> 
>> 125: static void* tls_data = 0;
>> 126: static const void* const tls_data1 = (const void*)0x111;
>> 127: static const void* const tls_data2 = (const void*)0x222;
> 
> Was this necessitated by the change to `void*`? If so I had not expected that.

I guess I could have changed the logging code to use `"%d", (int)(intptr_t)tls_data` and call it a day, but it would be ugly.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/14770#discussion_r1254138298


More information about the serviceability-dev mailing list