RFR: JDK-8293114: JVM should trim the native heap [v4]

Thomas Stuefe stuefe at openjdk.org
Fri Jul 7 08:53:58 UTC 2023


On Thu, 6 Jul 2023 16:57:56 GMT, Leo Korinth <lkorinth at openjdk.org> wrote:

>> Thomas Stuefe has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   last cleanups and shade feedback
>
> src/hotspot/share/runtime/trimNative.cpp line 78:
> 
>> 76:   static constexpr int safepoint_poll_ms = 250;
>> 77: 
>> 78:   static int64_t now() { return os::javaTimeMillis(); }
> 
> I think it would be better to not use CLOCK_REALTIME in case of clock changes by NTP etc.

Okay, changed to os::elapsedTime().

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/14781#discussion_r1255488363


More information about the serviceability-dev mailing list