RFR: 8311102: Write annotations in the classfile dumped by SA [v3]

Ashutosh Mehra duke at openjdk.org
Wed Jul 12 18:48:48 UTC 2023


On Tue, 11 Jul 2023 20:33:59 GMT, Chris Plummer <cjplummer at openjdk.org> wrote:

>> Ashutosh Mehra has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Some code motion and factoring out common code
>>   
>>   Signed-off-by: Ashutosh Mehra <asmehra at redhat.com>
>
> src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/oops/ConstMethod.java line 641:
> 
>> 639:   //            |                                           |
>> 640:   //            V                                           V
>> 641:   //            | ... | default | type | parameter | method |
> 
> So the `...` part is represented by `getSize()`? It would be good to call that out. Also point out that each of the annotations pointers is optional.

Updated the comment.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/14735#discussion_r1261592735


More information about the serviceability-dev mailing list