RFR: 8311556: GetThreadLocalStorage not working for vthreads mounted during JVMTI attach [v3]
Serguei Spitsyn
sspitsyn at openjdk.org
Thu Jul 13 01:28:57 UTC 2023
> This is an issue with a dynamic load of a JVMTI agent into running VM.
> The `VM_SetNotifyJvmtiEventsMode` enabling operation makes a call to the function `count_transitions_and_correct_jvmti_thread_states()`. This function in its turn make a call to the function `correct_jvmti_thread_state()`. But it does it conditionally, only if the field `_whitebox_used` is `true`.
> The test provided in the bug report showed that it has to be called unconditionally as the assumption that it is only needed on the subsequent `notifyJvmti` enabling is incorrect.
>
> Then the field `_whitebox_used` is not needed anymore and removed in this fix.
> Some obsolete comments are removed or updated.
>
> New test is added: `test/hotspot/jtreg/serviceability/jvmti/vthread/VThreadTLSTest`.
> It is failed without the fix and passed with the fix.
>
> Testing:
> - ran new test `test/hotspot/jtreg/serviceability/jvmti/vthread/VThreadTLSTest`
> - mach5 tiers 1-5 are good
Serguei Spitsyn has updated the pull request incrementally with one additional commit since the last revision:
review: renamed incorrectly spelled local variable
-------------
Changes:
- all: https://git.openjdk.org/jdk/pull/14842/files
- new: https://git.openjdk.org/jdk/pull/14842/files/743188b5..0a86e71d
Webrevs:
- full: https://webrevs.openjdk.org/?repo=jdk&pr=14842&range=02
- incr: https://webrevs.openjdk.org/?repo=jdk&pr=14842&range=01-02
Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod
Patch: https://git.openjdk.org/jdk/pull/14842.diff
Fetch: git fetch https://git.openjdk.org/jdk.git pull/14842/head:pull/14842
PR: https://git.openjdk.org/jdk/pull/14842
More information about the serviceability-dev
mailing list