Integrated: 8311556: GetThreadLocalStorage not working for vthreads mounted during JVMTI attach

Serguei Spitsyn sspitsyn at openjdk.org
Thu Jul 13 01:59:26 UTC 2023


On Wed, 12 Jul 2023 05:02:53 GMT, Serguei Spitsyn <sspitsyn at openjdk.org> wrote:

> This is an issue with a dynamic load of a JVMTI agent into running VM.
> The `VM_SetNotifyJvmtiEventsMode` enabling operation makes a call to the function `count_transitions_and_correct_jvmti_thread_states()`. This function in its turn make a call to the function `correct_jvmti_thread_state()`. But it does it conditionally, only if the field `_whitebox_used` is `true`.
> The test provided in the bug report showed that it has to be called unconditionally as the assumption that it is only needed on the subsequent `notifyJvmti` enabling is incorrect.
> 
> Then the field `_whitebox_used` is not needed anymore and removed in this fix.
> Some obsolete comments are removed or updated.
> 
> New test is added: `test/hotspot/jtreg/serviceability/jvmti/vthread/VThreadTLSTest`.
> It is failed without the fix and passed with the fix. 
> 
> Testing:
>   - ran new test `test/hotspot/jtreg/serviceability/jvmti/vthread/VThreadTLSTest`
>   - mach5 tiers 1-5 are good

This pull request has now been integrated.

Changeset: 11a5115c
Author:    Serguei Spitsyn <sspitsyn at openjdk.org>
URL:       https://git.openjdk.org/jdk/commit/11a5115caf179a1bbed5311e12ed3851e026c5c5
Stats:     196 lines in 3 files changed: 181 ins; 13 del; 2 mod

8311556: GetThreadLocalStorage not working for vthreads mounted during JVMTI attach

Reviewed-by: lmesnik, cjplummer

-------------

PR: https://git.openjdk.org/jdk/pull/14842


More information about the serviceability-dev mailing list