RFR: JDK-8293114: JVM should trim the native heap [v10]

Thomas Stuefe stuefe at openjdk.org
Fri Jul 14 06:10:23 UTC 2023


On Fri, 14 Jul 2023 04:47:23 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> Thomas Stuefe has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Bikeshed Trim log lines
>
> src/hotspot/share/runtime/trimNativeHeap.cpp line 83:
> 
>> 81: 
>> 82:   // in seconds
>> 83:   static double now() { return os::elapsedTime(); }
> 
> Do you need the wrapper for this rather than using `os::elapsedTime()` directly?

I rather keep it since it keeps the caller sites a bit better readable.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/14781#discussion_r1263332231


More information about the serviceability-dev mailing list